Update sabre/dav requirement from ~4.5.0 to ~4.6.0 #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [sabre/dav](https://github.com/sabre-io/dav) to permit the latest version. - [Release notes](https://github.com/sabre-io/dav/releases) - [Changelog](https://github.com/sabre-io/dav/blob/master/CHANGELOG.md) - [Commits](sabre-io/dav@4.5.0...4.6.0) --- updated-dependencies: - dependency-name: sabre/dav dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
@ByteHamster this should be OK to merge - there is nothing really exciting in |
|
Have you tested this inside Baikal before merging @phil-davis? |
No, sorry. I saw the CI green, but forgot that this repo does not have comprehensive unit or end-to-end tests. But 4.6 only enhances the dav client that is "bundled" in |
|
Yeah, I still usually test before merging, even if the changes seem small. At least for my other open source projects, dependency updates are one of the most common causes for regressions. I'm super cautious about dependency updates :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on sabre/dav to permit the latest version.
Release notes
Sourced from sabre/dav's releases.
Changelog
Sourced from sabre/dav's changelog.
... (truncated)
Commits
5541453Merge pull request #1527 from phil-davis/prepare-4.6.029d43f6chore: prepare release 4.6.0008ed42Merge pull request #1526 from phil-davis/issue-1041-4.6db80aaePreserve backward-compatibility of client propFind72548b7feat: adjust client PROPFIND methods to add types8a77009feat: tidy up client PROPFIND code and commentseece860feat: return PROPFIND properties indexed by status985e810feat: return all property-status combinations from PROPFINDeb50dc2test: adjust testPropFindUnfiltered to show multi-propstat behaviora93bd80feat: return both properties and status in propFindUnfilteredYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)