-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update french guide link #1260
Update french guide link #1260
Conversation
Update french guide link not accurate in README.md
Hmm, we had this on an external repo before and the repo went away. Maybe we could add it to the wiki of this repo instead? https://github.com/sabre-io/Baikal/wiki |
@ByteHamster I do not plan to delete the content, but in the worst case scenario, the link will just be broken. |
Opinions, @phil-davis? The person who owned the previous GitHub repo also said they don't plan to delete it, but still it's gone. Not sure if we want to officially support a guide in another language that we also didn't really fact-check. |
The content looks reasonable, and still has links to the old repo. So that is a clue that it is the content that was in the old repo - good. I made a PR to adjust those links: criticalsool/Baikal-Guide-FR#1 We should be better off having this new copy of the guide in French - might as well link to it. The alternative is to add these other-language guides to the Baikal repo itself, and ask people to make PRs when they want to correct/update them. |
Thanks for the PR, regarding your alternative, it sounds interesting. Choose what suits you best between that or leave it as a reference to my repository, I'll adapt. |
@ByteHamster I suggest that you can merge this for now. |
Thanks! |
Update french guide link not accurate in README.md