Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update french guide link #1260

Merged
merged 1 commit into from
May 29, 2024
Merged

Update french guide link #1260

merged 1 commit into from
May 29, 2024

Conversation

criticalsool
Copy link
Contributor

Update french guide link not accurate in README.md

Update french guide link not accurate in README.md
criticalsool referenced this pull request in YunoHost-Apps/baikal_ynh Apr 30, 2024
@ByteHamster
Copy link
Member

Hmm, we had this on an external repo before and the repo went away. Maybe we could add it to the wiki of this repo instead? https://github.com/sabre-io/Baikal/wiki

@criticalsool
Copy link
Contributor Author

@ByteHamster
At your convenience (feel free to copy the content into the wiki) but this guide is referenced in other places, I do not want to maintain it in several locations at the same time.

I do not plan to delete the content, but in the worst case scenario, the link will just be broken.

@ByteHamster
Copy link
Member

Opinions, @phil-davis? The person who owned the previous GitHub repo also said they don't plan to delete it, but still it's gone. Not sure if we want to officially support a guide in another language that we also didn't really fact-check.

@phil-davis
Copy link
Contributor

The content looks reasonable, and still has links to the old repo. So that is a clue that it is the content that was in the old repo - good.

I made a PR to adjust those links: criticalsool/Baikal-Guide-FR#1

We should be better off having this new copy of the guide in French - might as well link to it. The alternative is to add these other-language guides to the Baikal repo itself, and ask people to make PRs when they want to correct/update them.

@criticalsool
Copy link
Contributor Author

Thanks for the PR, regarding your alternative, it sounds interesting.
I could then delete my repository and reference the guide elsewhere directly from baikal.
That way, I'd be able to propose PR to the guide in baikal, furthermore, it would be easier for others to contribute than on my repository.

Choose what suits you best between that or leave it as a reference to my repository, I'll adapt.

@phil-davis
Copy link
Contributor

@ByteHamster I suggest that you can merge this for now.
And then you can decide if you would like to add the content directly to the Baikal repo.

@ByteHamster ByteHamster merged commit 9037d6f into sabre-io:master May 29, 2024
7 checks passed
@ByteHamster
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants