Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base uri on login screen #1273

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Use base uri on login screen #1273

merged 1 commit into from
Jul 13, 2024

Conversation

ByteHamster
Copy link
Member

Closes #1125

phil-davis
phil-davis approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.
The "old" code calling getCurrentUrl relies on $GLOBALS["_SERVER"]["REQUEST_URI"] giving a correct/useful value.
But users in the linked issue are reporting that that is not so, for some reverse proxy and/or containerized deployments.

@ByteHamster ByteHamster merged commit 2ee4be6 into sabre-io:master Jul 13, 2024
7 checks passed
@ByteHamster ByteHamster deleted the use-baseuri branch July 13, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authenticate button on /admin/ does not respect $base_uri
2 participants
@ByteHamster @phil-davis