-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct method is_sparse_paving
#39382
base: develop
Are you sure you want to change the base?
Conversation
Couldn't we just check that both M and M* (the dual of M) are paving - that's one of definitions in the literature. |
Whichever definition you use, please add a reference in the usual way, not here. |
Documentation preview for this PR (built with commit d894970; changes) is ready! 🎉 |
I agree with Dima's suggestion. Also, don't forget the |
Yes, we can. I tried to use an alternative characterization to avoid computation on the dual matroid (whose rank may be much larger). See the first example in the
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
It was brought to my attention that the method `is_sparse_paving` is incorrect. See sagemath#36962 (comment). The method should only check the symmetric differences of `r`-element circuits rather than all (`r`- and `r+1`-element) circuits. The algorithm used is based on a somewhat unusual definition which can be found in https://arxiv.org/pdf/math/0404200. URL: sagemath#39382 Reported by: gmou3 Reviewer(s): Travis Scrimshaw
It was brought to my attention that the method
is_sparse_paving
is incorrect. See #36962 (comment).The method should only check the symmetric differences of
r
-element circuits rather than all (r
- andr+1
-element) circuits.The algorithm used is based on a somewhat unusual definition which can be found in https://arxiv.org/pdf/math/0404200.