Add support for 3.12, drop EOL 3.7 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it all passes and builds the right wheels! Leaving this as a draft since if you don't get to it within a few days, there are probably going to be version bumps needed for the Python version specified in the setup-python action and cibuildwheel version. |
|
Thank you! |
saghul
approved these changes
Oct 2, 2023
|
I'm going to note that you can build wheels with RC versions of Python since they're the point at which there are no more ABI changes being made. So if you do happen to have time to cut a release sooner, you can do so safely with the current state of PR as well. |
|
Alright, I updated the PR to use stable Python 3.12 and updated cibuildwheel with the version using 3.12.0 for builds as well. |
saghul
approved these changes
Oct 6, 2023
|
Cheers! I'll cut out a release now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.12 untested, we'll see if the tests succeed or if there's more work needed. Dropping 3.7 as well since it's way past EOL.