Test data updates to fix test failures #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 2, 2024 00:43
saghul
approved these changes
Jan 2, 2024
|
Thank you! |
|
The jobscoutdaily.com SPF record changed again, so this now fails again: jobscoutdaily.com. 21600 IN TXT "v=spf1 A MX " "include:emailcampaigns.net include:spf.dynect.net include:ccsend.com include:_spf.elasticemail.com ip4:67.200.116.0/24 ip4:74.199.198.0/24 " " ~all" When I have time, I'll try to submit an updated PR, but it may be awhile. |
|
Or not. Now I'm not sure what's going on. |
|
So, it looks like they changed it a few months ago and then recently changed it back, so I think we're fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have multiple test failures with pycares 4.4.0 with c-ares 1.24. Two of the three are unrelated to the new c-ares version:
For test_query_txt_chunked, the jobscoutdaily.com SPF record changed, so the expected result is wrong. I think it still has the relevant attributes for the test case.
For test_query_ptr, there's no longer a PTR record at 8.8.8.8, so the test failed with pycares (correctly) reported an error. It looks like any address with a PTR record will meet the requirements for the test, so I replaced it with the address of one of Google's mail servers.
I'll submit a separate PR for the change related to the newer c-ares.
Scott K