-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the issue #54 #57
Conversation
Fixing individual translation files is inconsequential to the actual bug, which lies in either how the sahana.pot file or in the code itself based on the way the offending string was placed within the _t() function. And please do not commit personal changes to .htaccess. Thanks for the effort! Closed without merging. |
Sorry, Sir, for the ".htaccess" file. The translated text in fr_g.pog(for french) and ja_g.pog(for japanese) was written in the wrong way (actually anchor tag was not properly closed), so I corrected it and generated new ".mo" files (because ".mo" files are used for translation) using the instructions given in vesuvius/res/build_pog with the help of command "msgfmt -cv -o file.mo file.pog" and it resolved the issue #54 .
So, we are mainly concerned with "fr_g.mo" and "ja_g.mo" files, as they are responsible for the true translation of the given string. So these are the files that need to be updated. |
Hi @praful94, thanks for your input, but these translations files are of no major importance at this point. What we need to do is, regenerate the sahana.pot file using /res/build_pot.sh and see if the tag is not properly sent there again. If this is the issue, we need to fix the specific _t() function where the tag is included along with a string. I believe this is at https://github.com/sahana/vesuvius/blob/master/vesuvius/mod/report/main.inc#L72 |
Thanks sir for your reply. I got what you are saying, but please just have a look at the following once: At this time, snapshot of translating line in res/locale/fr_g.pog.You can clearly see improper anchor tag. 2) When french translation is correct At this time snapshot of translating in res/locale/fr_g.pog. You can clearly see properly corrected anchor tag I just request you to please try with these 4 updated files: I am sure it will correct the issue #54 . And if I'm wrong, can you please tell me what is the purpose of line 1470 in "fr_g.pog". Because I think that if this line is wrong, then translation will always get displayed wrong no matter what we do to string in _t() function. Thanks. |
Accepting this pull request to give kudos for effort. Thanks! |
Changed the files fr_g.pog, ja_g.pog and their corresponding .mo files - fr_g.mo, ja_g.mo - are generated by compiling the newly generated .pog files - in the folder /vesuvius/res/locale/ . Now "search" link is displayed correctly.
Only 4 files need to be changed.