Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Profiling System #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

wrongsahil
Copy link
Contributor

@wrongsahil wrongsahil commented Aug 23, 2016

Fixes #39

@mananpal1997
Copy link
Contributor

same code shouldn't be saved multiple times. Plus, I can't view the saved code.

@wrongsahil
Copy link
Contributor Author

@mananpal1997 I'll fix so that same code is not saved multiple times and for viewing the saved code, open the profile tab and then open the links in new tab for now.(anchor tags are not working correctly)

@sahildua2305
Copy link
Owner

@sahil865gupta Since this is a breaking change, can you please host this application as a test heroku app so that we can check the feature extensively?

@wrongsahil
Copy link
Contributor Author

@sahildua2305
Copy link
Owner

@sahil865gupta Thanks for your patience!

This looks really good. However I have some minor suggestions -

  1. UX: After saving, popup should close by itself.
  2. UX: When I open a saved code, it should open in new tab.

@wrongsahil
Copy link
Contributor Author

I'll fix these issues asap.


$("#title-save").click(function(){

// if a run request is ongoing
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all the code in this callback function is repeated, can you put it into a separate function and call it everywhere this code is repeated?

@sahildua2305
Copy link
Owner

@sahil865gupta do you need more time for this?

@wrongsahil
Copy link
Contributor Author

wrongsahil commented Nov 15, 2016

I was not able to do this because of exams but i'll do it today.

@wrongsahil
Copy link
Contributor Author

@sahildua2305 Does this seems ok now?

@sahildua2305
Copy link
Owner

@sahil865gupta did you work on these as well?

This looks really good. However I have some minor suggestions -
1) UX: After saving, popup should close by itself.
2) UX: When I open a saved code, it should open in new tab.

@wrongsahil
Copy link
Contributor Author

Yeah i have done that too. I updated the code at https://test-hackide.herokuapp.com/

@sahildua2305
Copy link
Owner

Hi @sahil865gupta, long time! :D

I wonder if you'd be up to try to merge this and ship this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement profiling system allowing users to make their profiles and saving codes in their profiles
3 participants