Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SS & correct api info #253

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Update SS & correct api info #253

merged 7 commits into from
Dec 4, 2023

Conversation

RaneyDazed
Copy link
Contributor

Please describe the purpose of this Pull Request.

Ensure correct API Key configuration for Sabnzbd connection in Radarr
and Sonarr settings, corrected sonarr category, added SS of both radarr and sonarr.

Ensure correct API Key configuration for Sabnzbd connection in Radarr
and Sonarr settings, corrected sonarr category, added SS of both radarr and sonarr.

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"
@RaneyDazed
Copy link
Contributor Author

Might be a good idea to link to sab docs too? Since I removed the 2 lines that linked to it to reference the user/pass?

@RaneyDazed
Copy link
Contributor Author

omg. I'll need to redo that. I think it renumbered the radarr page

@RaneyDazed
Copy link
Contributor Author

Ok, should be set. Unless you want to link to (../apps/sabnzbd) somewhere

@chazlarson
Copy link
Collaborator

chazlarson commented Dec 4, 2023

Why remove the link to the sab page? The edit is referring to an unidentified settings page, and I don't understand the point of explaining that an api key is used instead of a user/pass without saying why. Does user/pass not work?

@RaneyDazed
Copy link
Contributor Author

My bad, I thought it would be nice to reflect the sabnzbd.md page under docs/apps, and just specify that they needed the API key. I certainly didn't mean to be rude or anything. Jeez.

@RaneyDazed
Copy link
Contributor Author

I'll take different screen shots with user and pass

@chazlarson
Copy link
Collaborator

chazlarson commented Dec 4, 2023

No, that's not the point. Api key is fine if that's what works. The issue was that the first pass told them to get the api key from some random "settings", without identifying which settings, while removing the link that answered that question. Sure, probably the Sabnzbd settings, but in all the rest of these we point directly to where the user finds this, so we should here as well.

It also added a line that said api key is preferred without explaining why; if api key is preferred, then it makes sense to point the user to where they can find it; my initial remark was that I didn't understand why that link was removed.

If user/pass should remain blank because api key is preferred or something, say that explicitly along with the preferred bit to avoid "the docs don't say how to use user/pass".

If either work, then perhaps say that, again to avoid "how do I?" questions.

Copy link
Collaborator

@chazlarson chazlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no radarr page.

@chazlarson chazlarson merged commit 2451f85 into saltyorg:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants