Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid Cinder: Add FCD support #646

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Liquid Cinder: Add FCD support #646

merged 6 commits into from
Jan 20, 2025

Conversation

VoigtS
Copy link
Member

@VoigtS VoigtS commented Jan 17, 2025

This PR aims to support FCD checks from Pools to VolumeTypes via the StorageProtocol and the QualityType.
The old way of matching against the volumeBackendName is still available for the current Pools.

The catch on the new approach is that VolumeTypes might a Encryption attribute attachted to them at some point. Those will have the same StorageProtocol and QualityType as the the one without encryption.
This behavior is similar how we treat volumeBackendName already. The collected Pool capacity will just be split into the matching volumeTypes.

I tested the implementation against the cluster and yes, we do retrieve non-matching Pools into the resultset now.
Please have a look at this, there might be optimization that I can do. Other than that I will update the documentation for the new matching tomorrow.

Checklist:

  • If this PR is about a plugin, I tested the plugin against an OpenStack cluster.
    TODO:
  • I updated the documentation to describe the semantical or interface changes I introduced.

@coveralls
Copy link

coveralls commented Jan 17, 2025

Coverage Status

coverage: 79.255%. remained the same
when pulling 43d4ae0 on cinder_update
into 0757907 on master.

extract non matching pool log to ensure additional checks are easier to implement
add comments to type of check performed
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

docs/liquids/cinder.md Outdated Show resolved Hide resolved
Co-authored-by: Stefan Majewsky <[email protected]>
@VoigtS VoigtS merged commit ebcfee2 into master Jan 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants