Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to support FCD checks from Pools to VolumeTypes via the
StorageProtocol
and theQualityType
.The old way of matching against the
volumeBackendName
is still available for the current Pools.The catch on the new approach is that
VolumeTypes
might aEncryption
attribute attachted to them at some point. Those will have the sameStorageProtocol
andQualityType
as the the one without encryption.This behavior is similar how we treat
volumeBackendName
already. The collected Pool capacity will just be split into the matching volumeTypes.I tested the implementation against the cluster and yes, we do retrieve non-matching Pools into the resultset now.
Please have a look at this, there might be optimization that I can do. Other than that I will update the documentation for the new matching tomorrow.
Checklist:
TODO: