Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acpq quota overrides bug #654

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Acpq quota overrides bug #654

merged 4 commits into from
Feb 11, 2025

Conversation

Varsius
Copy link
Contributor

@Varsius Varsius commented Feb 4, 2025

Checklist:

  • If this PR is about a plugin, I tested the plugin against an OpenStack cluster.
  • I updated the documentation to describe the semantical or interface changes I introduced.

@coveralls
Copy link

coveralls commented Feb 4, 2025 •
edited
Loading

Coverage Status

coverage: 79.583% (+0.07%) from 79.51%
when pulling 4bf34e8 on acpq-quota-overrides-bug
into 610896c on master.

@Varsius Varsius force-pushed the acpq-quota-overrides-bug branch from 1c277c9 to ffd0710 Compare February 6, 2025 08:58
@Varsius Varsius marked this pull request as ready for review February 6, 2025 09:00
@Varsius Varsius requested a review from majewsky February 6, 2025 09:01
majewsky
majewsky requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I only have a few small nitpicks:

internal/datamodel/apply_computed_project_quota_test.go Outdated Show resolved Hide resolved
internal/datamodel/apply_computed_project_quota.go Outdated Show resolved Hide resolved
internal/datamodel/apply_computed_project_quota.go Outdated Show resolved Hide resolved
internal/datamodel/apply_computed_project_quota.go Outdated Show resolved Hide resolved
@Varsius Varsius requested a review from wagnerd3 as a code owner February 11, 2025 12:12
@Varsius Varsius requested a review from majewsky February 11, 2025 12:12
@majewsky majewsky merged commit 89768ce into master Feb 11, 2025
6 checks passed
@majewsky majewsky deleted the acpq-quota-overrides-bug branch February 11, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777 Nuckal777 is a code owner

@wagnerd3 wagnerd3 Awaiting requested review from wagnerd3 wagnerd3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Varsius @coveralls @majewsky