add limes_project_commitment_min_expires_at metric #659
Conversation
wagnerd3
requested review from
majewsky,
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
docs/operators/metrics.md
Outdated
| | Gauge | `limes_project_usage` | `service`, `resource`, `domain`, `domain_id`, `project`, `project_id` | | ||
| | Type | Metric | Labels | | ||
| |-------|-----------------------------------------------------|----------------------------------------------------------------------------------------------------| | ||
| | Gauge | `limes_autogrow_growth_multiplier` | `service`, `resource` | |
There was a problem hiding this comment.
I completed the list with all missing metrics from collector/metrics.go. Did not know if the other metrics were missing on purpose or whether this was just forgotten.
wagnerd3
force-pushed
the
min_expiresAt_metric
branch
from
1ccaa51 to
2502f34
Compare
wagnerd3
force-pushed
the
min_expiresAt_metric
branch
from
2502f34 to
444dff4
Compare
| @@ -9,10 +9,10 @@ The API service exposes the standard HTTP metrics generated by the standard Go c | |||
|
|
|||
There was a problem hiding this comment.
One question regarding markdown: My IDE automatically formatted the tables with whitespaces so that the | borders align. I disabled this now, as I saw this only sometimes being done - e.g. not in this file. Would it be desirable to somehow auto-style the markdown?
There was a problem hiding this comment.
I prefer this style on the basis of my editor not having automatic alignment like this, so I would just break it when I edit the files again the next time. But not a strong preference from my side.
| @@ -9,10 +9,10 @@ The API service exposes the standard HTTP metrics generated by the standard Go c | |||
|
|
|||
There was a problem hiding this comment.
I prefer this style on the basis of my editor not having automatic alignment like this, so I would just break it when I edit the files again the next time. But not a strong preference from my side.
Checklist:
If this PR is about a plugin, I tested the plugin against an OpenStack cluster.Local check:
