Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arrays): add unique #141

Merged
merged 24 commits into from
Jul 7, 2022
Merged

feat(arrays): add unique #141

merged 24 commits into from
Jul 7, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #141 (81bc711) into main (f5375af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   99.26%   99.27%           
=======================================
  Files          53       54    +1     
  Lines        3137     3161   +24     
  Branches      777      786    +9     
=======================================
+ Hits         3114     3138   +24     
  Misses         13       13           
  Partials       10       10           
Impacted Files Coverage Δ
src/constraints/ArrayConstraints.ts 100.00% <100.00%> (ø)
src/constraints/util/isUnique.ts 100.00% <100.00%> (ø)
src/validators/ArrayValidator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5375af...81bc711. Read the comment docs.

src/validators/ArrayValidator.ts Outdated Show resolved Hide resolved
src/validators/ArrayValidator.ts Outdated Show resolved Hide resolved
tests/validators/array.test.ts Outdated Show resolved Hide resolved
src/validators/ArrayValidator.ts Outdated Show resolved Hide resolved
src/validators/ArrayValidator.ts Outdated Show resolved Hide resolved
kyranet
kyranet previously requested changes Jul 4, 2022
src/validators/ArrayValidator.ts Outdated Show resolved Hide resolved
favna
favna previously approved these changes Jul 4, 2022
src/constraints/util/isUnique.ts Outdated Show resolved Hide resolved
tests/validators/array.test.ts Show resolved Hide resolved
@vladfrangu
Copy link
Member

Can you also just make sure this bundles correctly for browsers? (ideally it should put lodash.uniqwith in the bundle) 🙏

@favna
Copy link
Member

favna commented Jul 6, 2022

Can you also just make sure this bundles correctly for browsers? (ideally it should put lodash.uniqwith in the bundle) 🙏

barring the usages of node's inspect the repo will now (again) be browser ready after this PR + #149

@favna favna changed the title feat(ArrayValidator): add unique feat(arrays): add unique Jul 6, 2022
.github/workflows/continuous-integration.yml Show resolved Hide resolved
src/constraints/util/isUnique.ts Outdated Show resolved Hide resolved
@favna favna merged commit ad7af34 into sapphiredev:main Jul 7, 2022
@imranbarbhuiya imranbarbhuiya deleted the feat/add-required branch July 7, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants