Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rpcs support #318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

enomis-dev
Copy link
Contributor

@enomis-dev enomis-dev commented Mar 14, 2022

Linked to #316
This pull request aims to improve methods: copy_with(), footprint(), corners(), corner(), origin(), center(), resize() for rasters provided with rpcs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #318 (12832b6) into master (2fe4388) will increase coverage by 0.03%.
The diff coverage is 96.22%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   90.86%   90.90%   +0.03%     
==========================================
  Files          38       38              
  Lines        6130     6176      +46     
==========================================
+ Hits         5570     5614      +44     
- Misses        560      562       +2     
Impacted Files Coverage Δ
telluric/georaster.py 93.41% <93.33%> (-0.03%) ⬇️
tests/test_georaster.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe4388...12832b6. Read the comment docs.

@enomis-dev
Copy link
Contributor Author

Recently, I've seen that the current approach used to get corners and footprint could lead to error in mountains regions, further tests should be done.

@enomis-dev enomis-dev marked this pull request as draft March 25, 2022 22:17
@enomis-dev enomis-dev marked this pull request as ready for review April 26, 2022 10:49
@enomis-dev
Copy link
Contributor Author

Recently, I've seen that the current approach used to get corners and footprint could lead to error in mountains regions, further tests should be done.

I added the possibility to pass the dem in the kwargs of the functions in case you want to get more precise results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants