changed main file for sync view and changed show_details file for box… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrgiorgio
reviewed
Nov 13, 2024
app/main.py
Outdated
| y1, y2 = [C + ((value - c) / (d - c)) * (D - C) for value in [y, y + h]] | ||
| slice2.canvas.setViewport([x1, y1, x2 - x1, y2 - y1]) | ||
| slice2.refresh("SyncSlices") | ||
| def SyncSlices(slice1, slice2, box1=None, box2=None): |
There was a problem hiding this comment.
can you merge functions to avoid replication of code (syncSlices and reverse)?
also no to use global... you can use variables inside the class (i.e. if there are two couples of synced-images it will not work)
There was a problem hiding this comment.
syncSlices and reverse are merged. removed global variables and included them in the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… select option