Automatic columns selector for joins function #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find out common columns between the 2 datasets and use the common columns in them as column-selector This change introduces a new arity in left-join function
genmeblog
reviewed
Sep 3, 2024
There was a problem hiding this comment.
You don't have to change api.clj file since it's generated. https://github.com/scicloj/tablecloth/blob/master/src/tablecloth/api/api_template.clj#L182
genmeblog
requested changes
Sep 3, 2024
| @@ -53,22 +53,35 @@ | |||
| (impl [(first cols-left) (first cols-right)] ds-left ds-right (or options {})) | |||
| (multi-join impl ds-left ds-right cols-left cols-right options)))) | |||
|
|
|||
| (defn- automatic-columns-selector [ds-left ds-right] | |||
| (let [cols-l (set (column-names ds-left :all)) | |||
| @@ -53,22 +53,35 @@ | |||
| (impl [(first cols-left) (first cols-right)] ds-left ds-right (or options {})) | |||
| (multi-join impl ds-left ds-right cols-left cols-right options)))) | |||
|
|
|||
| (defn- automatic-columns-selector [ds-left ds-right] | |||
| (let [cols-l (set (column-names ds-left :all)) | |||
| cols-r (set (column-names ds-right :all))] | |||
pcbldi
force-pushed
the
joins-automatic-column-selector
branch
from
a32c8af to
6702403
Compare
thanks, should I revert the changes in that ns completely? or its ok to leave what changes are there? |
|
very useful, I was thinking about requesting this as well,as such common case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes introduces an automatic column selector as discussed in #133 .
All the common columns in two datasets are used as the column selectors.