add typings #33
Open
add typings #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikolalysenko : let me know if you have questions |
rreusser
reviewed
Dec 20, 2016
| hi(...args: number[]): NdArray; | ||
| step(...args: number[]): NdArray; | ||
| transpose(...args: number[]): NdArray; | ||
| pick(...args: number[]): NdArray; |
There was a problem hiding this comment.
Does this allow null or undefined values? Need to think it through, but a couple of the functions allow null or undefined values when meaningful.
|
@rreusser Good point! I come back to you with a fix ASAP. |
|
Because https://github.com/scijs/ndarray/blob/master/ndarray.js is the only main file makes up this repository, then how about rewriting this javascript program into typescript completely? There could be no needs to maintain some snips for different module system or different es versions, like the practice in rxjs |
|
When the PR will be ready? |
|
@dmromanov I saw there is already here, https://www.npmjs.com/package/@types/ndarray. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include typescript definitions