Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to parallel mode? #540

Closed
mjankowski opened this issue Jan 14, 2025 · 4 comments
Closed

Default to parallel mode? #540

mjankowski opened this issue Jan 14, 2025 · 4 comments

Comments

@mjankowski
Copy link
Contributor

Happy to prepare PR for this, just wanted to confirm desirable first...

I believe rubocop defaults to parallel mode, and I expected haml-lint would as well (once I learned it had a parallel mode).

Any objection to changing that default?

@sds
Copy link
Owner

sds commented Jan 14, 2025

Supportive, though we may want to consider adding the ability to specify the level of parallelism, rather than always assuming the user wants to allocate all available CPUs. That said, not a blocker.

@mjankowski
Copy link
Contributor Author

Great, started to put something together, will open PR when ready ... could maybe do env var or something as followup for the "how many CPUs" aspect (I think rubocop does that?)

Separately, I noticed a few other things while attempting to get set up, curious what if any of these you'd be open for PRs on...

  • Some of the appraisal/gemspec/gemfile defs seem a little of out of sync?
  • Haml 6.3 support missing from appraisals (and tool in general)?
  • Ruby 3.3 and 3.4 missing from CI matrix

@sds
Copy link
Owner

sds commented Jan 16, 2025

  • Updating the appraisal specs sounds great
  • Adding HAML 6.3 + Ruby 3.3 + 3.4 to the build matrix seems reasonable

Thanks!

@sds
Copy link
Owner

sds commented Jan 16, 2025

Implemented in #541. Thank you.

@sds sds closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants