Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to parallel true #541

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Default to parallel true #541

merged 2 commits into from
Jan 16, 2025

Conversation

mjankowski
Copy link
Contributor

Background: #540

There didn't seem to be other default options set in this way at the options class level. To the extent there are defaults, they seem sort of spread around in constants or local context appropriate ways. Let me know if there's a different preferred way to do that.

  • Changes parallel run default to true
  • Adds --no-parallel option to turn it off
  • Preserves behavior of previous --parallel option (though sort of moot now)

Possible follow-up -- do something with env vars or otherwise to specify number of CPU to use, instead of full parallel.

@sds sds merged commit e8af19f into sds:main Jan 16, 2025
34 checks passed
@mjankowski mjankowski deleted the options-thing branch January 16, 2025 18:12
@sds sds mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants