Make node_for_line return the last possible node when nothing matches #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxLap
force-pushed
the
fix_node_for_line
branch
from
b66937e to
49b6748
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitten by HAML's parser anoying behavior of just merging lines into one without leaving any trace!
I fixed a problem in
line_numberswhen I made the RuboCop refactor, so the line count was more accurate. But that highlighted the lack of handling for multiline scripts in that method.I'm patching
node_for_linebecause managing to make line_numbers more accurate would require quite a bit of monkey-patching or probably mean a performance hit for something that is quite rarely needed.Fixes #451