Fix rendering of the Number type

[ddssff]

Do not use the the Show instance of Clay.Property.Number for rendering. Instead add an instance of Pretty that uses the showFixed function of the underlying Fixed value. Adds a test case to spec/Clay/MediaSpec.hs that demonstrates the resulting output of the keyframes function.

[turion]

Ah, I wasn't aware the rendering of Number is broken. Can you give an example of what went wrong?

[ddssff]

Without fix:

Number {unNumber = 0.00000}% {visibility:visible;}

With fix:

0% {visibility:visible;}

It is assuming the automatically derived Show instance is a renderer, the way the show instance for Double is. In my opinion, it is better to use the Pretty printer for this.

[ddssff]

But you could just replace the call to show with showFixed True . unNumber

[turion]

I think even better would be to use fromText $ cssNumberText p. I definitely wouldn't want to incur an extra dependency for this.

[ddssff]

Whatever works!

[ddssff]

Ok, pretty dependency removed.

[turion]

There are some warnings about redundant imports that should be fixed, otherwise looking great!

[ddssff]

Looks good.

[ddssff]

👍 Not sure how these reviews are supposed to work.

[ddssff]

Warnings fixed.

[turion]

Thanks a lot!