Explicit push to the gateway #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juligasa
added
type: enhancement
burdiyan
reviewed
Jan 8, 2024
juligasa
force-pushed
the
feat/gw-direct-push
branch
from
d4bc3f5
to
c1cc30b
Compare
burdiyan
reviewed
Jan 9, 2024
burdiyan
reviewed
Jan 9, 2024
burdiyan
reviewed
Jan 9, 2024
burdiyan
reviewed
Jan 9, 2024
burdiyan
reviewed
Jan 9, 2024
|
LGTM. Could merge, as long as we understand that the |
juligasa
force-pushed
the
feat/gw-direct-push
branch
from
2c3afa6
to
dd8bf22
Compare
burdiyan
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncing.allow-pushthat allows any mintter daemon to be pushed content. If that flag is false, then only group members can push content. regular p2p daemon will get content by regular periodic syncing.PushPublicationthat once called, blocks until it either succeeds in pushing content to the gateway or fails. It pushes the document version requested + supported materials. It is a remote call on the site which will look if it already has the blobs before engaging in any syncing operation, therefore It's safe to "abuse" it.