Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dictionary to dedicated page #458

Open
wants to merge 4 commits into
base: prod
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
clean up
kkemple committed May 20, 2022
commit 5ecf7f2a9be89148bb41bb78dda7547a1738ddea
3 changes: 0 additions & 3 deletions 11ty/_includes/components/base/site-footer.njk
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<footer class="site-footer">
<nav aria-label="Complimentary">
<ul class="navigation-list">
<li>
<a href="/content-warning-guidelines/">Content Warning Guidelines</a>
</li>
<li>
<a href="{{ metadata.feedPermalink | absoluteUrl(metadata.url) }}">RSS Feed</a>
</li>
34 changes: 16 additions & 18 deletions 11ty/_includes/layouts/definition.njk
Original file line number Diff line number Diff line change
@@ -4,22 +4,20 @@
{% set description = 'The definition of ' + title + ' in Self-Defined, a modern dictionary about us.'%}

{% block content %}
<div class="wide-content">
{% include 'components/sub-page-header.njk' %}
<main>
<article class="definition">
<header class="definition__header">
{% definitionFlag flag %}
<h1 class="main-headline" >{{ title }}</h1>
<section class="u-margin-bottom-double" aria-labelledby="definition-speech">
<h2 id="definition-speech" class="visually-hidden">Speech</h2>
<p class="definition-content__speech">{{ speech }}</p>
</section>
</header>
{% include 'components/content-warning-flag.njk' %}
{% include 'components/definition-content.njk' %}
{% include 'components/alertbox.njk' %}
{% renderDefinitionContentNextEntries title, slug, collections.definedWords %}
</article>
</main>
<main>
<article class="definition">
<header class="definition__header">
{% definitionFlag flag %}
<h1 class="main-headline" >{{ title }}</h1>
<section class="u-margin-bottom-double" aria-labelledby="definition-speech">
<h2 id="definition-speech" class="visually-hidden">Speech</h2>
<p class="definition-content__speech">{{ speech }}</p>
</section>
</header>
{% include 'components/content-warning-flag.njk' %}
{% include 'components/definition-content.njk' %}
{% include 'components/alertbox.njk' %}
{% renderDefinitionContentNextEntries title, slug, collections.definedWords %}
</article>
</main>
{% endblock %}
1 change: 1 addition & 0 deletions assets/css/layouts/_pages.scss
Original file line number Diff line number Diff line change
@@ -17,6 +17,7 @@
}

.definition {
margin: auto;
max-width: 47rem;
}

11 changes: 0 additions & 11 deletions assets/css/structures/_definition-content.scss
Original file line number Diff line number Diff line change
@@ -18,17 +18,6 @@
margin-top: 2rem;
}

@supports (display: grid) {
// align-items: flex-start;
display: grid;
grid-gap: 1rem;
grid-template-columns: 1fr 4fr;

& > * {
margin: 0 !important;
}
}

& > p,
& > ul {
font-family: $sans-serif;