Add in Proxy URL for Alert for #1484 #1487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fiftin would be good to see your thoughts on this. It adds extra security controls for those in environments where proxies are deployed. Those that don't have them needn't configure it. |
|
@fiftin Can this be re-reviewed please. Would be nice to have this setup so we can proceed with resolving the ability to proxy the notifications. |
|
Can this be looked into please. Its a small non-impacting change to the working of the built in alert system providing the users the ability to restrict the required access for features to work in secure environments. |
|
@fiftin any potential to look into this minor change that improves a lot of functionaility in security controlled environments please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds in the Proxy parameter to to send alerts outbound for #1484
The user is prompted for the Proxy URL when using the setup command. If the user leaves the url blank, then the proxy settings are left as default.
I have only been able to validate this using Slack as that's all I use.
But i don't see a reason why the same code won't work on the Telegram function either. If anyone wants to test and validate the Telegram alerts using the proxy URL settings, then feel free to do so.
You could potentially use different proxies for the different alerts if the user so wished, but I figure most environments that are using proxies will use a standard proxy for the hosts.