Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update Swift #523

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NinjaLikesCheez
Copy link

@NinjaLikesCheez NinjaLikesCheez commented Jan 16, 2025

Checklist

  • Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
  • Change has no security implications (otherwise, ping the security team)

I've opened this MR to update an aging Swift grammer. Semgrep is unable to scan most Swift files I've tried it against (because of things like freestanding #Preview macros).

I'm not fully up to speed on item one on this list, so I've marked this as a WIP until I can figure that piece out (but I'm away from my computer from Saturday for a week - so it may take a while).

Thanks!

@NinjaLikesCheez NinjaLikesCheez requested a review from a team as a code owner January 16, 2025 15:35
@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

@aryx aryx requested a review from nmote January 16, 2025 15:50
@nmote nmote marked this pull request as draft January 16, 2025 17:02
@nmote
Copy link
Collaborator

nmote commented Jan 16, 2025

Thanks! Marking as draft while you are working on this. Please mark as ready for review once that is the case!

@NinjaLikesCheez
Copy link
Author

@nmote No problem! I've followed the guide (although it's a little confusing in place - especially when I've never touched a lot of these technologies!). I'm unsure how to properly test that this will integrate fine with semgrep. Do you have any advice or documentation I could take a look at?

I've been following this: https://semgrep.dev/docs/contributing/updating-a-grammar but of course I can't do the release part - I wanted to verify nothing has broken by updating this grammar first however.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants