Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Published Rules - aaronmiller_personal_org.node-uuid-v1-usage #3522

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

semgrep-dev-pr-bot[bot]
Copy link
Contributor

Wahoo! New published rules with aaronmiller_personal_org.node-uuid-v1-usage from @aaronhmiller.

See semgrep.dev/s/v8Nrl for more details.

Thanks for your contribution! ❤️

subcategory:
- guardrail
cwe:
- 'CWE 330: Use of Insufficiently Random Values'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'CWE 330: Use of Insufficiently Random Values'
- 'CWE-330: Use of Insufficiently Random Values'

metadata:
category: security
subcategory:
- guardrail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- guardrail
- secure default

@0xDC0DE
Copy link
Contributor

0xDC0DE commented Dec 11, 2024

Hi @aaronhmiller . This rule does not have valid testcode. Can you rewrite the testcode to include at least one positive and one negative testcase and mark it with correct test syntax?

There is also some lints failing.

  • The subcategory guardrail is not valid. We typically use secure default.
  • The format for the CWE is CWE-XXX

Copy link

@aaronhmiller aaronhmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepting wise advice...tests TBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants