Add check requests #154
Add check requests #154
Conversation
|
Awesome stuff. Do you think requesting many checks is a common use-case? What do you think about a modal with a "Request" button for UX instead? A modal might be nice additionally so we can truncate the check command line, but show the full value in the modal (since some checks like graphite URLs get really wide). |
|
100% agree with you, requesting multiple checks is unlikely to ever be used, I just followed the checkbox system from the other pages. A modal would be nicer, and also solve the problem with extra long command lines. I'm pretty busy at the moment but will definitely work on switching to the modal when I get a chance! |
| @@ -9,3 +9,22 @@ namespace "SensuDashboard.Models", (exports) -> | |||
| interval: 60 | |||
|
|
|||
| idAttribute: "name" | |||
|
|
|||
| request: (options = {}) => | |||
There was a problem hiding this comment.
Is this needed? You should be able to save the model and Backbone JS should take care of the rest.
|
Most of the code looks great. Take a look at a few of the other models; writing jQuery AJAX requests shouldn't be necessary with Backbone JS (with the exception of the call in the bootstrapper code). |
|
This looks close enough to merge for me. I like the modal idea, but don't need to block this functionality if others like it. Thoughts @joemiller? |
|
I would like to see a run-check button in the individual event modal someday but I don't think we should block adding it to the Checkbox/Actions drop-down. |
|
@Fizzadar @amdprophet can we resurrect this discussion? |
| @selectNone() | ||
| error: (model) => | ||
| @errorCallback.call(this, model) if @errorCallback | ||
| @selectNone() |
|
I'll merge this in once I get a chance to test it. |
This adds the ability to manually run check requests via the dashboard. Will only work with Sensu version '0.11.0' as the API appears to have changed in 0.12.0 and I can't find any documentation on it (assume WIP as the default version Apt installs is 0.11.0).
Apologies for the code, learning Ruby & Coffee on the fly here - will not be offended if this request is deleted/not-merged!