#35 - Added support for stripping host from metric #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. Can this please be merged? |
nikkictl
suggested changes
Aug 26, 2020
There was a problem hiding this comment.
I'm trying to get some additional feedback about the original issue (see #35 (comment) if you can provide more context about the use case).
In the meantime, I've left some comments about the way the test is structured. This will allow you to enrich the test with more cases, including what the expected behavior should be when the strip host flag is not set. Please let me know if you have any questions about that, and thanks again for your contribution!
|
Thank you for your review. I will apply the changes later today. |
…ed more test cases
|
Pushed the code review changes. |
nikkictl
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve issue #35