Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 128-bit integers in flatten structs and internally tagged enums #2781

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add support for 128-bit integers in flatten structs and internally tagged enums #2781

wants to merge 8 commits into from

Commits on Sep 7, 2024

  1. Test with support of 128-bit integers in serde_test

    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    2090126 View commit details
    Browse the repository at this point in the history

  2. Group all tests of newtype variant in newtype module 

    (review this commit with "ignore whitespace changes" option on)
    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    58d01bf View commit details
    Browse the repository at this point in the history

  3. Use i128 and u128 in tests for internally tagged enums 

    failures (5):
    newtype::enum_::newtype   (deserialize)
    newtype::enum_::struct_   (serialize)
    newtype::enum_::tuple     (serialize)
    newtype::struct_          (deserialize)
    struct_                   (deserialize)
    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    fba5ee6 View commit details
    Browse the repository at this point in the history

  4. Add tests for failed serialization of primitives in newtype variants … 

    …of internally tagged enums

Deserialization not checked because there is no sequence of tokens
that could represent test values

failures (7):
    newtype::enum_::newtype   (deserialize)
    newtype::enum_::struct    (serialize)
    newtype::enum_::tuple     (serialize)
    newtype::i128             (serialize)
    newtype::struct_          (deserialize)
    newtype::u128             (serialize)
    struct_                   (deserialize)
    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    5bdaf31 View commit details
    Browse the repository at this point in the history

  5. Add tests with nested primitive in newtype in newtype variant 

    failures (8):
    newtype::enum_::newtype   (deserialize)
    newtype::enum_::struct_   (serialize)
    newtype::enum_::tuple     (serialize)
    newtype::i128             (serialize)
    newtype::newtype_struct   (deserialize)
    newtype::struct_          (deserialize)
    newtype::u128             (serialize)
    struct_                   (deserialize)
    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    881413d View commit details
    Browse the repository at this point in the history

  6. Add ability to cache i128/u128 during serialization 

    `Content` size doesn't changed, because it is already big enough
(64 bytes due to `TupleVariant` and `StructVariant`).

Fixes (2):
    newtype::i128             (serialize)
    newtype::u128             (serialize)

failures (6):
    newtype::enum_::newtype   (deserialize)
    newtype::enum_:;struct    (deserialize)
    newtype::enum_::tuple     (deserialize)
    newtype::newtype_struct   (deserialize)
    newtype::struct_          (deserialize)
    struct_                   (deserialize)
    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    ed638a0 View commit details
    Browse the repository at this point in the history

  7. Make methods to create Unexpected i128/u128 values public

    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    1137c5a View commit details
    Browse the repository at this point in the history

  8. Support deserialization of i128/u128 in flatten structs and internall… 

    …y tagged enums

Fixed (6):
    newtype::enum_::newtype
    newtype::enum_::struct_
    newtype::enum_::tuple
    newtype::newtype_struct
    newtype::struct_
    struct_
    @Mingun
    Mingun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    84c80e2 View commit details
    Browse the repository at this point in the history