Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve Typescript SQS standard example #710

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

[Feature] Improve Typescript SQS standard example #710

wants to merge 2 commits into from

Conversation

Pigius
Copy link
Contributor

@Pigius Pigius commented Aug 6, 2022

Hi @pgrzesik!

Couple of improvements:

  • readme
  • add missing TS types,
  • Use the lift plugin (queue construct) to create a standard SQS queue,
  • update packages
  • use the newest possible node runtime.
  • use HTTP API as it was agreed.

@pgrzesik
Copy link
Contributor

pgrzesik commented Aug 7, 2022

Hey @Pigius - I don't have access to this repo anymore, you might need to request @mnapoli or @medikoo for a review here

mnapoli
mnapoli reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added some inline comments for improvements.

aws-node-typescript-sqs-standard/handlers/receiver.ts Show resolved Hide resolved
aws-node-typescript-sqs-standard/handlers/sender.ts Outdated Show resolved Hide resolved
aws-node-typescript-sqs-standard/handlers/sender.ts Outdated Show resolved Hide resolved
aws-node-typescript-sqs-standard/serverless.yml Outdated Show resolved Hide resolved
aws-node-typescript-sqs-standard/serverless.yml Outdated Show resolved Hide resolved
aws-node-typescript-sqs-standard/README.md Outdated Show resolved Hide resolved
@Pigius
Copy link
Contributor Author

Pigius commented Sep 24, 2022

Hi @mnapoli sorry, I did not receive any GH notifications, so, I was not aware of your comments. I've fixed them now!

@Pigius Pigius force-pushed the feature/improve-typescript-sqs-standard-example branch from 15ba239 to 53420c5 Compare September 28, 2022 18:29
@Pigius
Copy link
Contributor Author

Pigius commented Sep 28, 2022

@medikoo could you please check this PR as well? I've done the PR comments from @mnapoli 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnapoli mnapoli mnapoli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pigius @pgrzesik @mnapoli