Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teleport to stage start command #1207

Merged
merged 8 commits into from
Apr 27, 2024
Merged

Conversation

Awesomerly
Copy link
Contributor

@Awesomerly Awesomerly commented Apr 24, 2024

On KSF, the defacto CSS surf server, there is a command called /teleport. What it does is take you back to the previous zone you were in without stopping the timer. On bhop the penalty for failing a stage isn't very bad because the ground isn't far away from the player and stages aren't as important to that gamemode, but in surf it can alleviate players from having to fall for 3 seconds just to get back to the stage they were on.

I still need feedback on this.

@Awesomerly Awesomerly marked this pull request as draft April 24, 2024 16:12
@Awesomerly
Copy link
Contributor Author

Awesomerly commented Apr 24, 2024

One thing I realized is that there's already a tele command in bhoptimer that teleports to a checkpoint. On KSF /teleport also takes you to the last checkpoint in their similar-but-less-fleshed-out version of the Segmented style... I think that it may be a good idea to come up with a different official name for this command but keep /teleport as one of the names so that surfers don't have to change their binds.

@Awesomerly Awesomerly marked this pull request as ready for review April 24, 2024 16:25
@ddorab
Copy link

ddorab commented Apr 24, 2024

bind x "sm_tele; sm_teleport", unless there's a tele command in surf as well that's all they need to do
also I thought it was meant to be an alias for tele but your thing has the same functionality as ksf where it teleports you to the last zone you were in?

@Awesomerly
Copy link
Contributor Author

Awesomerly commented Apr 24, 2024

I thought it was meant to be an alias for tele

There's only sm_tele, no sm_teleport defined in shavit-checkpoints;

RegConsoleCmd("sm_cpmenu", Command_Checkpoints, "Opens the checkpoints menu.");
RegConsoleCmd("sm_cp", Command_Checkpoints, "Opens the checkpoints menu. Alias for sm_cpmenu.");
RegConsoleCmd("sm_checkpoint", Command_Checkpoints, "Opens the checkpoints menu. Alias for sm_cpmenu.");
RegConsoleCmd("sm_checkpoints", Command_Checkpoints, "Opens the checkpoints menu. Alias for sm_cpmenu.");
RegConsoleCmd("sm_save", Command_Save, "Saves a checkpoint.");
RegConsoleCmd("sm_tele", Command_Tele, "Teleports to a checkpoint. Usage: sm_tele [number]");
RegConsoleCmd("sm_prevcp", Command_PrevCheckpoint, "Selects the previous checkpoint.");
RegConsoleCmd("sm_nextcp", Command_NextCheckpoint, "Selects the next checkpoint.");
RegConsoleCmd("sm_deletecp", Command_DeleteCheckpoint, "Deletes the current checkpoint.");

but your thing has the same functionality as ksf where it teleports you to the last zone you were in?

I wonder if there's a better name for this command that I cooked up. The aliasing thing seems like a decent idea if that's the case. I will have to talk to other surfers about this.

As far as I can tell the functionality to teleport you to the last zone you were in is not in bhoptimer. I use that command a lot in surf... so much so that I have it bound to q.

@ddorab
Copy link

ddorab commented Apr 24, 2024

well sm_tele teleports you to the last checkpoint, so I thought you would do RegConsoleCmd("sm_teleport", Command_Tele, "Teleports to a checkpoint. Usage: sm_tele [number]"); so that players wouldn't have to change their binds but stage zones are not common at all in bhop and players don't really teleport to the last stage anyway like you said. It's up to 🥑to decide whether teleporting to last stage is needed but I just got confused by what you wanted

@Awesomerly Awesomerly changed the title Add teleport command Add teleport to stage start command Apr 24, 2024
@Awesomerly
Copy link
Contributor Author

Awesomerly commented Apr 24, 2024

What you said made me think about something; I could make it so that the teleport to last stage command doesn't work in segmented/tas modes, then tell surfers to alias sm_teleport to be sm_tele and sm_stagerestart or w/e it should be called.

Side note: The reason I am thinking about surfers so much is because I know a few people that use bhoptimer to run surf servers because it's the best choice for an open source timer in general. The KSF timer is the highest quality CSS surf, but it is closed-source and so the competitive surf scene centralizes on KSF servers. think it's a good thing for surfers to have alternative servers for when they want to escape the umbrella of KSF. To assist people in doing that, it may be good to implement some surf-centric features like surf-style startzone rules and nojump zones in a way that doesn't get in the way of bhop server owners and players.

There's actually a fork of bhoptimer called shavitsurftimer that adds a bunch of surf-centric features but it seems to be half-broken sadly; maybe it would be a good idea to get in contact with them...

@rtldg rtldg merged commit 2805cd9 into shavitush:master Apr 27, 2024
2 checks passed
@Awesomerly Awesomerly deleted the sm_teleport branch April 27, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants