Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for Python 3.8 #2266

Open
ppfeister opened this issue Aug 23, 2024 · 0 comments · May be fixed by #2267
Open

Deprecate support for Python 3.8 #2266

ppfeister opened this issue Aug 23, 2024 · 0 comments · May be fixed by #2267
Assignees
@ppfeister
Labels
bug Something isn't working

Comments

@ppfeister
Copy link
Member

ppfeister commented Aug 23, 2024 •
edited
Loading

Description

Some versions of pandas and numpy are incompatible, and the compatible versions of pandas is not compatible with Python versions below 3.9. Since Python 3.8 is reaching EOL in about a month anyways, support for this version should now be deprecated to allow for more ready dependency resolution and avoidance of this fatal error.

Traceback (most recent call last):
  File "/home/[redacted]/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.12/bin/sherlock", line 3, in <module>
    from sherlock_project.sherlock import main
  File "/home/[redacted]/Documents/sherlock/sherlock_project/sherlock.py", line 21, in <module>
    import pandas as pd
  File "/home/[redacted]/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.12/lib64/python3.12/site-packages/pandas/__init__.py", line 22, in <module>
    from pandas.compat import is_numpy_dev as _is_numpy_dev  # pyright: ignore # noqa:F401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/[redacted]/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.12/lib64/python3.12/site-packages/pandas/compat/__init__.py", line 25, in <module>
    from pandas.compat.numpy import (
  File "/home/[redacted]/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.12/lib64/python3.12/site-packages/pandas/compat/numpy/__init__.py", line 4, in <module>
    from pandas.util.version import Version
  File "/home/[redacted]/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.12/lib64/python3.12/site-packages/pandas/util/__init__.py", line 2, in <module>
    from pandas.util._decorators import (  # noqa:F401
  File "/home/[redacted]/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.12/lib64/python3.12/site-packages/pandas/util/_decorators.py", line 14, in <module>
    from pandas._libs.properties import cache_readonly
  File "/home/[redacted]/.cache/pypoetry/virtualenvs/sherlock-project-VJORHILj-py3.12/lib64/python3.12/site-packages/pandas/_libs/__init__.py", line 13, in <module>
    from pandas._libs.interval import Interval
  File "pandas/_libs/interval.pyx", line 1, in init pandas._libs.interval
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
@ppfeister ppfeister added the bug Something isn't working label Aug 23, 2024
@ppfeister ppfeister self-assigned this Aug 23, 2024
@ppfeister ppfeister linked a pull request Aug 23, 2024 that will close this issue
Open
@ppfeister ppfeister linked a pull request Aug 23, 2024 that will close this issue
Deprecate Python 3.8 #2267
Open
ppfeister added a commit that referenced this issue Aug 23, 2024
@ppfeister
Deprecate Python 3.8
f5ed90c 
Python 3.8 is nearing EOL, and it's being deprecated here to allow for
more ready dependency resolution between pandas and numpy, avoiding a
fatal import. Resolves #2266.
ppfeister added a commit that referenced this issue Aug 23, 2024
@ppfeister
Deprecate Python 3.8
ed200ab 
Python 3.8 is nearing EOL, and it's being deprecated here to allow for
more ready dependency resolution between pandas and numpy, avoiding a
fatal import. Resolves #2266.
ppfeister added a commit that referenced this issue Aug 23, 2024
@ppfeister
Deprecate Python 3.8
c6c1f3e 
Python 3.8 is nearing EOL, and it's being deprecated here to allow for
more ready dependency resolution between pandas and numpy, avoiding a
fatal import. Resolves #2266.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppfeister ppfeister

Labels
bug Something isn't working
Projects
Release 0.16.0
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate Python 3.8 sherlock-project/sherlock
1 participant
@ppfeister