Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.8 #2267

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

ppfeister
Copy link
Member

Python 3.8 is nearing EOL, and it's being deprecated here to allow for more ready dependency resolution between pandas and numpy, avoiding a fatal import.

fc39 will be EOL November 12, 2024, and most users should have upgraded to fc40 by now, so I don't see much reason to continue support for that either.

Closes #2266

@ppfeister ppfeister added the bug Something isn't working label Aug 23, 2024
@ppfeister ppfeister self-assigned this Aug 23, 2024
@ppfeister ppfeister linked an issue Aug 23, 2024 that may be closed by this pull request
@ppfeister ppfeister removed their assignment Aug 23, 2024
@ppfeister ppfeister force-pushed the 2266-deprecate-support-for-python-38 branch 3 times, most recently from ed200ab to c6c1f3e Compare August 23, 2024 05:15
Python 3.8 is nearing EOL, and it's being deprecated here to allow for
more ready dependency resolution between pandas and numpy, avoiding a
fatal import. Resolves #2266.
@ppfeister
Copy link
Member Author

Now that fc39 and 3.8 are finally EOL, I don't see any reason to keep withholding a merge. Any opposition to said merge? @sdushantha

Simple deprecation of 3.8. Should have no functional difference, although the pandas issue may also become less prevalent (as a positive side effect).

Copy link
Collaborator

@matheusfelipeog matheusfelipeog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing against it at the moment. Sounds good.

@sdushantha
Copy link
Member

LGTM

@ppfeister ppfeister merged commit 8f5d601 into master Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deprecate support for Python 3.8
3 participants