Common internal #102
Merged
Common internal #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARM CPUs don't include the same fields as x86 and amd64 CPUs in the /proc/cpuinfo list. Pull information from the /sys/... device tree as well as updating when a CPU is done in cpuinfo. Fixes shirou#88
Package common wasn't used for public functions. Place it in an internal directory to prevent other packages from using. Remove the distributed references to "HOST_PROC" and "HOST_SYS" consts and combine into a common function. This also helps so that if a env var is defined with a trailing slash all will continue to work as expected. Fixes shirou#100
|
Thanks! Can the |
|
It compiles just fine in go1.4, just like any other folder; in go1.4 it is only enforced for the std lib. For go1.5 it is enforced for all. So yes, it will still compile and function for go1.4. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the "common" package behind the internal folder so it is not part of an API promise, implicit or explicit.