Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update awards.md (Alined award same place like source to reduce navigation effort of user) #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TimothyRbz
Copy link
Contributor

Adapted sources structure to reduce click/scroll effort of reader
(Yes i double commented)

Fixes

Fixes #[issue number] by @[issue author]

Description

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow the contribution guidelines.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
Further Conditions
(e) This contribution does not grant me any rights to use the
    name of the project, the name of the author, the name of the
    organization, or the name of the author's organization in any
    advertising or publicity relating to this project or the
    contribution.
(f) This contribution does not grant me rights to any trademark or service
    mark belonging to the project, the author, the organization, or the
    author's organization.

Adapted sources structure to reduce click/scroll effort of reader
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12837421873

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-1.2%) to 50.858%

Files with Coverage Reduction New Missed Lines %
src/app/pages/translate/drop-pose-file/drop-pose-file.component.ts 1 31.82%
src/app/core/services/tfjs/tfjs.loader.ts 2 78.57%
src/app/core/modules/ngxs/store/video/video.state.ts 5 89.8%
src/app/modules/pose/pose.service.ts 6 81.3%
src/app/pages/translate/signed-to-spoken/signed-to-spoken.component.ts 6 48.48%
src/app/components/animation/animation.component.ts 7 39.29%
src/app/components/speech-to-text/speech-to-text.component.ts 9 36.0%
Totals Coverage Status
Change from base Build 12745238392: -1.2%
Covered Lines: 1239
Relevant Lines: 2352

💛 - Coveralls

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 01cadeb):

https://translate-sign-mt--pr199-timothyrbz-patch-7-kn0cfk9o.web.app

(expires Fri, 24 Jan 2025 21:56:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 739446cfe7a349700ebd347d2a39e3b90ba24425

@@ -1,33 +1,23 @@
# Awards and Recognition

In this page, we list the awards and recognition that the technology behind sign.mt has received in the last few years, alongside public independent reviews.
In this page, we list the awards and recognition that the technology behind sign.mt and Dr. Amit Moryossef has received in the last few years, alongside public independent reviews.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentence doesn't read right to me, I prefer the initial writing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe because it is not grammatical, it should be have. but I still prefer the initial writing

Copy link
Contributor Author

@TimothyRbz TimothyRbz Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok agree, do i now just resolve the conversation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you make an edit to this line, it will probably auto-resolve. Otherwise, you can manually resolve


- sign.mt was independently reviewed for Kazakh-Russian Sign Language translation, reporting accuracy of 37% compared to 98% for human translation[^kazakh-russian-review].
- We received an `EMNLP Outstanding Demo Paper Award` for our demonstration of "sign.mt: Real-Time Multilingual Sign Language Translation Application". sign.mt. 2024. [Twitter Post](https://x.com/signmt_/status/1857181686045540787).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to help with the file readability, not website readability, you could create a new line. it doesn't format it as a new line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, a style to write inline citations would be sign.mt, 2024 (comma, instead of .) and then the link, so something like:

- We received an `EMNLP Outstanding Demo Paper Award` for our demonstration of "sign.mt: Real-Time Multilingual Sign Language Translation Application"[^emnlp2024-award]. 
([sign.mt, 2024](https://x.com/signmt_/status/1857181686045540787).

[^emnlp2024-award]: sign.mt. 2024. [Twitter Post](https://x.com/signmt_/status/1857181686045540787).

This would add the link in a more prominent, east-to-navigate place, while also including the full citation in references.

- Dr. Amit Moryossef (among others) received the `ACL Outstanding Paper Award` for "Considerations for Meaningful Sign Language Machine Translation"[^acl2023-award].

[^acl2023-award]: Müller et al. 2023. [Considerations for Meaningful Sign Language Machine Translation](https://aclanthology.org/2023.acl-short.60/).
- Dr. Amit Moryossef (among others) received the `ACL Outstanding Paper Award` for "Considerations for Meaningful Sign Language Machine Translation". Müller et al. 2023. [Considerations for Meaningful Sign Language Machine Translation](https://aclanthology.org/2023.acl-short.60/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the reasons for having the citation as the link, is that it would remove the redundancy of writing the name of the paper twice, here and elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants