-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the use of the Google Closure compiler for minifying and optimizing generated javascript #126
base: master
Are you sure you want to change the base?
Allow the use of the Google Closure compiler for minifying and optimizing generated javascript #126
Conversation
I didn't write any additional tests for this because none of the functions seemed particularly testable. |
Forgot to add the dependencies, but they are there now. Adds one additional dependency 'network-uri' |
having a hell of a time satisfying the network uri dependency |
Thanks for the pull request, Unfortunately there are a number of issues i see with this approach:
Extending what I wrote in #122 (comment) I'd rather we introduce a function |
Actually, this is already possible by calling |
When are you planning to merge your gen modular branch? I could try moving some of the code over there and also adding in a command line compiler. As for the dependencies, I can use http-client instead of HTTP I just thought you were already using network (because of yaml file for jenkins) |
Fixes issue #122