JavaFX basic plugin with button

[tassadarius]

Hallo Simon,

ich habe jetzt analysis.friedman genommen und in den Core geschoben, sonst aber nichts geändert. Ich hoffe das passt so, sonst melde dich einfach.

Liebe Grüße

---

This change is 

[simlei]

Hi, thanks for the PR for figuring out this javafx stuff.
First, a few nitpicks on form:

• .project was missing in the friedman plugin
• together with the already existing friedman plugin in "crypto" repository, we have a duplicate plugin. A dedicated plugin for reproducing this would have been ideal (I see you had started this in [1] but this is way too little to avoid confusion of eclipse over this)
  [1] https://github.com/simlei/core/pull/2/files#diff-e665c706ec01ae5ded2f4957a5a11b64R22
• A few lines on which project and which file to open and which line to uncomment to get to the error won't hurt. Don't hide the error behind comments, the more straight into the face it jumps the better since this is an error search PR.
• It was made bad together with the missing .project file, because Eclipse was not even importing the friedman project into my workspace, so I had to jump through two hoops (where is the project?, where is the knob to turn to see the error?)

Just ask yourself "what could be missing for the reveiving person to get going quickly?" next time, please, or more straightforward, just quickly try to work on your own PR for a few minutes from a different repo. As a fix, I added the missing .project file, and disabled the old "friedman" plugin in my crypto repository. Now that we have it working, let's not change it any more. But after working nearly an hour to get started with debugging, I thought, 15min more to tell you where it could be better next time, could not hurt.

Following, the same text as is attached to my answer PR:

---

I think, the javafx binaries are now pulled in. In any case we should sync up. Please try to run the friedman plugin in org.jcryptool.analysis.friedman. Please review the diff of the PR as it is quite compact to see where I made changes.

I currently get different errors than when I started out, and the error seems to be a JNI binary one, suggesting, that now it tries to load the javafx native components. Are you getting anything like this?

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f175ad512b7, pid=793, tid=0x00007f180b041700
#

In the error search I noticed that there have been quite a few changes in the e(fx)clipse packages. They tried to sort it out but produced old forum threads that do not reflect the current state of doing things.

Most importantly, you hear often that you have to use for Java VM arguments:

1. -Dosgi.framework.extensions=org.eclipse.fx.osgi
   and also that you need
2. -Dorg.osgi.framework.bundle.parent=ext
   Sometimes, a person says, 1) is not necessary, sometimes, 2) is not necessary. It changed with e(fx)clipse version 2.0, but not everywhere 🙁 The best way seems to be to include both.

Regarding the launch parameters to the VM, the most useful thread is:

[1] https://www.eclipse.org/forums/index.php/t/1087013/ and see post https://www.eclipse.org/forums/index.php?t=msg&th=1087013&goto=1768852&#msg_1768852 and beyond for clarifications on that matter. Post https://www.eclipse.org/forums/index.php?t=msg&th=1087013&goto=1770753&#msg_1770753 is a happy user who made it after those clarifications. I followed these steps. Post https://www.eclipse.org/forums/index.php?t=msg&th=1087013&goto=1770765&#msg_1770765 points to the tutorial which is supposed to help most with this use case; please also read that when having questions about how to proceed best on further errors.

Another useful thread is: https://www.eclipse.org/forums/index.php/t/1087038/

In investigating this further, you could consider opening a Thread in these eclipse forums and pinging the user "Thomas Schindl" about the issue, as he seems to be one of the more knowledgeable folk in these discussions. I think he may even maintain part of e(fx)clipse. You could point him to this string of PR's for code / target platform parts.

Note, that you should make sure to set the VM arguments also in the RunConfiguration (Green "Play" button to launch JCT) and check whether org.eclipse.fx.osgi is included in the plugin/feature list. I have already included it in the product configuration, but from user's comments, this seems to be necessary still. Screenshot: