-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sanitizer #3346
base: main
Are you sure you want to change the base?
Add Sanitizer #3346
Conversation
readme.md
Outdated
@@ -632,6 +632,7 @@ | |||
- [Lockpicking](https://github.com/fabacab/awesome-lockpicking#readme) - The art of unlocking a lock by manipulating its components without the key. | |||
- [Cybersecurity Blue Team](https://github.com/fabacab/awesome-cybersecurity-blueteam#readme) - Groups of individuals who identify security flaws in information technology systems. | |||
- [Fuzzing](https://github.com/cpuu/awesome-fuzzing#readme) - Automated software testing technique that involves feeding pseudo-randomly generated input data. | |||
- [Sanitizer](https://github.com/junwha/awesome-sanitizer#readme) - Dynamic tools that detect software bugs through compiler instrumentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @junwha ,
Thanks for creating an Awesome list.
According to the requirements, you need to add your entry in the end of the list.
Also, please have a look at the linting errors:
Will be good to rename Contributing.md
to contributing.md
or contributing
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments! I fixed the lint errors, but I think the following lint outputs are false positives mentioned in the issue sindresorhus/awesome-lint#194.
✖ 146:3 https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#addresssanitizer remark-lint:double-link
✖ 147:3 https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#hwaddresssanitizer remark-lint:double-link
✖ 159:3 https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#threadsanitizer remark-lint:double-link
✖ 163:3 https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#memorysanitizer remark-lint:double-link
✖ [16](https://github.com/junwha/awesome-sanitizer/actions/runs/13087751967/job/36520919523#step:3:17)4:3 https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#memtagsanitizer remark-lint:double-link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @junwha , thanks for the reply, yes, I understood, if you have a look at the CI report of the PR https://github.com/sindresorhus/awesome/actions/runs/13087653258/job/36520729623?pr=3346 there are a bit different errors there as well (apart from remark-lint:double-link
):
✖ 29:1 Unexpected unordered list marker +, expected - remark-lint:unordered-list-marker-style
✖ 186:106 List item description contains invalid markdown remark-lint:awesome-list-item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see you fixed those, thanks
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Hi @sindresorhus, thank you for taking the time to leave a comment. I've put a lot of effort into curating this list over time while carefully following the guidelines, but I may have overlooked some aspects. I’d appreciate it if you could point out the key areas where it could be improved. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you used a markdown generator to create the Table of Contents. Could you rewrite that so it is not generated? Also, I noticed there was a section called Etc. Is this an "other" section? If so, it may be clearer if you labeled it with Miscellaneous. Thanks!
https://github.com/junwha/awesome-sanitizer
This is a curated list of sanitizers, which are dynamic tools that detect software bugs through compiler instrumentation. Since sanitizer is a crucial part of fuzzing and bug analysis, it needs to be included in the Security section of the awesome list.
My reviews PRs:
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it. Direct link with hash in contents is marked as double-link awesome-lint#194main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.