-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Free mode with basic ui #387
Conversation
93ab117
to
1866b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMADTSC
@@ -206,6 +206,8 @@ export const WorkoutEditor = ({ | |||
</InputGroup> | |||
</FormControl> | |||
|
|||
<Text fontWeight={'light'}>Tip:Use 0 as watt target for Free Mode</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can call it free mode for now, but I can't really see Free mode_ being used as a term. Some mention Resistance mode, Standard mode and SIM mode – we should decide what to call this 🤠
Anyways, I have some minor suggestions for the text itself, and I also suggest moving the text beneath the Add part button.
<Text fontSize="small">
Tip: Use 0 as power target for <em>Free mode</em>
</Text>
aka:
- Use
fontSize
instead offontWeight
- We don't need
{}
around component String params - Add spacing after
Tip:
- Call it Power target instead of Watt target, since there is a column named Power above said field
- Free mode instead of Free Mode – That's also what's been used the other places it is mentioned in this PR 🤓
- Add emphasis around
Free mode
Adds basic free mode support.
Just an MVP, but should be fine
Treats 0 as free mode, and then shows this in the UI.
Adds a helping text in the editor to help peopple
For later: