Removed deprecated flag --sdk-auth #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm I'm a bit unclear here on what to do. Is it broken either way? |
|
Hey @heiskr |
|
@heiskr |
heiskr
approved these changes
Apr 30, 2024
hectorsector
added a commit
that referenced
this pull request
Jul 9, 2024
This reverts commit 681b464.
2 tasks
hectorsector
added a commit
that referenced
this pull request
Jul 10, 2024
* Revert "Removed deprecated flag --sdk-auth (#78)" This reverts commit 681b464. * fix indents and numbering for step 1 * fix indents and numbering for step 2 * fix indents and numbering for step 3 * update subscription id example * use CR_PAT for GCR stuffs, with write permissions * Update .github/steps/2-setup-azure-environment.md Co-authored-by: Kevin Heis <[email protected]> --------- Co-authored-by: Kevin Heis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The flag --sdk-auth for az ad sp command has been deprecated and will be removed in a future release
A warning will be issued if this step is executed in the lab.
Changes
Removing the deprecated --sdk-auth flag for Step 2
Please also take a look at this comment: issue, since the problem becomes bigger - it's not possible to authorize with azure/login Action using the az ad sp (without --sdk-auth), because the outputs are not valid for AZURE_CREDENTIALS
Task list