Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ToC in Presenter Mode #1936

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: ToC in Presenter Mode #1936

wants to merge 2 commits into from

Conversation

rajxsingh
Copy link

Issue

When clicking on a link in the Toc Component in presenter mode, it exits presenter mode unintentionally. This disrupts the presenter experience by requiring the user to re-enter presenter mode, interrupting the flow.

Solution

Modify the TocList component to prepend /presenter to each item's path when $slidev.nav.isPresenter is true.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 68d63ed
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/672a1d566e65380008650d55
😎 Deploy Preview https://deploy-preview-1936--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rajxsingh rajxsingh marked this pull request as ready for review November 5, 2024 12:57
Copy link

pkg-pr-new bot commented Nov 5, 2024

Open in Stackblitz

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1936

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1936

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1936

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1936

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1936

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1936

commit: 68d63ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants