Add fetching and displaying description files #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzeekk
reviewed
Dec 15, 2024
There was a problem hiding this comment.
Interesting approach to replace relative Urls. I did not yet think about that...
Maybe we could also use the following feature of react-markup instead - it has a transformLinkUri and transformImageUri option, see https://github.com/remarkjs/react-markdown/tree/8.0.3.
So the fetchAPI would need another interface method getDescriptionUriTransform, which would be given as option to Markdown component in src/components/ConfigExplorer/DescriptionTab.tsx.
WDYT?
zzeekk
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELCA_SMARTDATALAKE-270
For this issue, I have put a comment in the JIRA ticket about how to handle URLs in markdown files. Could you please have a look at that and also do a review for this PR? I will make any correction as necessary.