SNOW-1890482 New telemetry validation in the E2E test added #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation & Context JIRA: SNOW-1797964 Setup CI-CD Pipeline ### Description Setup CI-CD Pipeline ### How Has This Been Tested? All checks have passed ### Checklist <!--- Please put an `x` in all the boxes that apply. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Data correction (data quality issue originating from upstream source or dataset) - [ ] Cleanup and optimization (improvement that does not alter the data returned by a model) - [ X] Other (please specify) ### Review & Approval Requests <!--- Use this section to request review and approval from specific individuals. --> <!--- Include any relevant instructions for each reviewer and approver. --> **Note**: Use GitHub's [draft PR feature](https://github.blog/news-insights/product-news/introducing-draft-pull-requests/) instead of tagging a PR as `DO NOT MERGE`.
…-checks Refactor functions, documentation, updating demos, and additional data types.
* Improved hypothesis-snowpark-security --severity-threshold=high
* Fix unit tests and refactor code * Adjusted .github/workflows files * Adjusted and Skipped snowpark-checkpoints-collector integration test * Fix error inconsistencies and improve value extraction * In Progress, .github/workflows/snowpark-checkpoints-publish.yml --------- Co-authored-by: Diego Babb Jimenez <[email protected]>
* Fix unit tests and refactor code * Adjusted .github/workflows files * Added .github/workflows/snowpark_checkpoint * Fix All Issues found from python linter ruff * Skipped testcases from snowpark_checkpoints-use-tests_all.yml --------- Co-authored-by: Diego Babb Jimenez <[email protected]>
Added Risk Assessment PR template
* Install and config snow-cli for testing checkpoints for supported environments
…arity and functionality
…ks-and-custom-steps
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…me in configuration package (#94)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Carlos Azofeifa <[email protected]>
… collection packages (#97)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sfc-gh-mfigueroamontero
previously approved these changes
Jan 29, 2025
sfc-gh-dchaconbarrantes
requested changes
Jan 29, 2025
sfc-gh-dchaconbarrantes
approved these changes
Jan 29, 2025
sfc-gh-cazofeifamadrigal
force-pushed
the
main
branch
from
630568d to
df10684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Context
JIRA: SNOW-1890482
New telemetry validation added in the E2E test
Description
This pull request introduces several changes to the
snowpark-checkpoints-testingproject, focusing on enhancing telemetry validation. The most important changes include updating the end-to-end tests to validate telemetry data.Telemetry Validation Enhancements:
snowpark-checkpoints-testing/src/utils/validations.py: Added a new functionvalidate_telemetry_datato validate telemetry data files against expected data for a given execution mode.End-to-End Test Updates:
snowpark-checkpoints-testing/test/e2e/test_e2e_checkpoints.py: Updated the end-to-end test functiontest_e2e_checkpointsto include validation of telemetry data. Added the import for the newvalidate_telemetry_datafunction.How Has This Been Tested?
Run the new automated tests
Checklist
Note: Use GitHub's draft PR feature instead of tagging a PR as
DO NOT MERGE.