build: promote tsan ci to must-pass

Refs: libuv#3681
socketsupply · Jan 20, 2023 · 67063ea · 67063ea
1 parent a3b7dfc
commit 67063ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/sanitizer.yml b/.github/workflows/sanitizer.yml
@@ -47,9 +47,10 @@ jobs:
           (cd build-tsan && cmake .. -G Ninja -DBUILD_TESTING=ON -DTSAN=ON -DCMAKE_BUILD_TYPE=Release)
           cmake --build build-tsan
       - name: TSAN Test
-        continue-on-error: true # currently permit failures
+        # Note: path must be absolute because some tests chdir.
+        # TSan exits with an error when it can't find the file.
         run: |
-          ./build-tsan/uv_run_tests_a
+          env TSAN_OPTIONS="suppressions=$PWD/tsansupp.txt" ./build-tsan/uv_run_tests_a
 
       - name: UBSAN Build
         run: |

diff --git a/tsansupp.txt b/tsansupp.txt
@@ -0,0 +1,2 @@
+# glibc reads `count` field unsynchronized, not a libuv bug
+race:pthread_barrier_destroy
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# glibc reads `count` field unsynchronized, not a libuv bug
		race:pthread_barrier_destroy