Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline processing guide #686

Closed
wants to merge 7 commits into from
Closed

Offline processing guide #686

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23c1e51
WIP
WojciechBarczynski Aug 23, 2024
0b6d374
Add generate
WojciechBarczynski Aug 23, 2024
de1e758
Unify guide layout
WojciechBarczynski Aug 26, 2024
1b225ae
Fix generating offline_processing
WojciechBarczynski Aug 26, 2024
2da875a
Add result video
WojciechBarczynski Aug 26, 2024
c02b01c
Update generated video
WojciechBarczynski Aug 26, 2024
5b77225
Fix grammar
WojciechBarczynski Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/pages/guides/basic-layouts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Update output to render a [`View`](../api/components/View.md) component with an
type: :view,
background_color_rgba: "#4d4d4dff",
children: [
%{ type: :input_stream, input_id: :input_1 }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to use strings instead of atoms for input ids everywhere for consistency.
It's also the typing used in docs: https://hexdocs.pm/membrane_live_compositor_plugin/Membrane.LiveCompositor.html#t:input_id/0

%{ type: :input_stream, input_id: "input_1" }
]
}
}
Expand Down Expand Up @@ -108,7 +108,7 @@ Wrap an [`InputStream`](../api/components/InputStream.md) component with a [`Res
children: [
%{
type: :rescaler,
child: %{ type: :input_stream, input_id: :input_1 }
child: %{ type: :input_stream, input_id: "input_1" }
}
]
}
Expand Down Expand Up @@ -173,11 +173,11 @@ Add another [`InputStream`](../api/components/InputStream.md) wrapped with [`Res
children: [
%{
type: :rescaler,
child: %{ type: :input_stream, input_id: :input_1 }
child: %{ type: :input_stream, input_id: "input_1" }
},
%{
type: :rescaler,
child: %{ type: :input_stream, input_id: :input_2 }
child: %{ type: :input_stream, input_id: "input_2" }
}
]
}
Expand Down Expand Up @@ -245,15 +245,15 @@ Specify `width` and `height` of one of the `Rescaler` components and position it
children: [
%{
type: :rescaler,
child: %{ type: :input_stream, input_id: :input_1 }
child: %{ type: :input_stream, input_id: "input_1" }
},
%{
type: :rescaler,
width: 320,
height: 180,
top: 20,
right: 20,
child: %{ type: :input_stream, input_id: :input_2 }
child: %{ type: :input_stream, input_id: "input_2" }
}
]
}
Expand Down
Loading