Support input NV12 textures #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerzywilczek
force-pushed
the
@jerzywilczek/nv12-support
branch
from
2a4cf85
to
b26987f
Compare
wkozyra95
approved these changes
Sep 11, 2024
| @@ -182,6 +189,15 @@ impl InputTexture { | |||
| error!("Invalid texture passed as an input: {err}") | |||
| } | |||
| } | |||
| InputTextureState::Nv12WgpuTexture(texture) => { | |||
| let texture = NV12TextureView::from_wgpu_texture(texture.as_ref()); | |||
| let bind_group = texture.new_bind_group(ctx, ctx.format.nv12_layout()); | |||
There was a problem hiding this comment.
what will happen if the passed texture is not nv12?
e.g. for rgba texture with do some validation inside fill_from_wgpu_texture
WojciechBarczynski
approved these changes
Sep 12, 2024
Comment on lines
+63
to
+82
| pub(super) fn new_bind_group( | ||
| &self, | ||
| ctx: &WgpuCtx, | ||
| layout: &wgpu::BindGroupLayout, | ||
| ) -> wgpu::BindGroup { | ||
| ctx.device.create_bind_group(&wgpu::BindGroupDescriptor { | ||
| label: Some("nv12 texture bind group"), | ||
| layout, | ||
| entries: &[ | ||
| wgpu::BindGroupEntry { | ||
| binding: 0, | ||
| resource: wgpu::BindingResource::TextureView(&self.view_y), | ||
| }, | ||
| wgpu::BindGroupEntry { | ||
| binding: 1, | ||
| resource: wgpu::BindingResource::TextureView(&self.view_uv), | ||
| }, | ||
| ], | ||
| }) | ||
| } |
There was a problem hiding this comment.
This can be created just once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #750