fix(iOS): full screen modal crash on paper #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksg
force-pushed
the
@maksg/fix-paper-full-screen-modal-crash
branch
from
e0c58eb
to
9e16a3f
Compare
kkafar
reviewed
Sep 12, 2024
|
Also, what's going on this this failing e2e CI on iOS? |
|
Done |
kkafar
approved these changes
Oct 4, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Full screen modal was crashing sometimes on Paper. Fixes software-mansion#2317. ## Test code and steps to reproduce Added `Test2317` to tests. ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <[email protected]>
kkafar
pushed a commit
that referenced
this pull request
Oct 25, 2024
Full screen modal was crashing sometimes on Paper. Fixes #2317. Added `Test2317` to tests. - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <[email protected]> (cherry picked from commit af30489)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Full screen modal was crashing sometimes on Paper.
Fixes #2317.
Test code and steps to reproduce
Added
Test2317to tests.Checklist