Fix issue when using Safari to authenticate #46
Conversation
|
Just a question, why you chose |
I was not choosing, just shared other man's approach, because it succeeded :) |
|
@VitaliyAdamkov can you please rebase on master and remove this commit 05d3a3a? |
done |
| spree.send("spree_user_#{method.provider}_omniauth_authorize_path"), | ||
| title: I18n.t('spree.sign_in_with', provider: method.provider)) if method.active %> | ||
| spree.send("spree_user_#{method.provider}_omniauth_authorize_path", r: rand), | ||
| title: Spree.t(:sign_in_with, provider: method.provider)) if method.active %> |
There was a problem hiding this comment.
@VitaliyAdamkov I like this change, removing I18n from views is an improvement 👍
But Spree.t has been deprecated in Solidus (see issue solidusio/solidus/issues/2773) and we're trying to remove it from the extensions as well. Can you please change this to something like t('spree.sign_in_with' ... ?
There was a problem hiding this comment.
@VitaliyAdamkov thank you 👍.
I have one last request, can you please squash the two commits into a single one? I think this would make git history cleaner and tidier... thank you!
|
Merged 🎉 thanks @VitaliyAdamkov |
omniauth/omniauth-oauth2#58 (comment)