Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file location of spree/line_item_action.rb #5923

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 14, 2024

When this was moved to the correct gem, we failed to also move it to the right directory. This generates Zeitwerk errors.

When this was moved to the correct gem, we failed to also move it to the
right directory. This generates Zeitwerk errors.
@mamhoff mamhoff requested a review from a team as a code owner November 14, 2024 16:10
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Nov 14, 2024
@tvdeyen tvdeyen added the backport-v4.4 Backport this pull-request to v4.4 label Nov 14, 2024
@tvdeyen
Copy link
Member

tvdeyen commented Nov 14, 2024

This should fix failing specs in solidusio/solidus_starter_frontend#374

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (8ff6267) to head (8710da9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5923      +/-   ##
==========================================
+ Coverage   87.81%   89.54%   +1.72%     
==========================================
  Files         476      782     +306     
  Lines       11656    17988    +6332     
==========================================
+ Hits        10236    16107    +5871     
- Misses       1420     1881     +461     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit e6e0243 into solidusio:main Nov 14, 2024
18 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.4 Backport this pull-request to v4.4 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants