Make all tests async #545
Merged
Make all tests async #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7.x.x #545 +/- ##
=======================================
Coverage 77.12% 77.12%
=======================================
Files 87 87
Lines 8551 8551
=======================================
Hits 6595 6595
Misses 1956 1956 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0xTim
approved these changes
Jun 16, 2023
| @@ -401,14 +399,14 @@ class AWSClientTests: XCTestCase { | |||
| let threadPool = NIOThreadPool(numberOfThreads: 3) | |||
| threadPool.start() | |||
| let fileIO = NonBlockingFileIO(threadPool: threadPool) | |||
| let fileHandle = try fileIO.openFile(path: filename, mode: .read, eventLoop: httpClient.eventLoopGroup.next()).wait() | |||
| let fileHandle = try await fileIO.openFile(path: filename, mode: .read, eventLoop: httpClient.eventLoopGroup.next()).get() | |||
There was a problem hiding this comment.
We could really do with a new async version of FileIO, preferably with an AsyncSequence
| eventLoop.flatSubmit { | ||
| return self.callback(eventLoop).map { $0 } | ||
| } | ||
| func getCredential(on eventLoop: EventLoop, logger: Logger) async throws -> Credential { |
There was a problem hiding this comment.
I'm assuming passing the event loop will disappear in a future API
| @@ -18,7 +18,8 @@ import SotoCore | |||
| import SotoTestUtils | |||
| import XCTest | |||
|
|
|||
| class EndpointDiscoveryTests: XCTestCase { | |||
| @available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *) | |||
There was a problem hiding this comment.
The next PR will fix these
| import NIOCore | ||
| import NIOPosix | ||
| @testable import SotoCore | ||
| import SotoTestUtils | ||
| import XCTest | ||
|
|
||
| class PaginateTests: XCTestCase { | ||
| @available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *) |
adam-fowler
added a commit
that referenced
this pull request
Jun 18, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Jul 24, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Jul 29, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Aug 12, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Dec 24, 2023
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
adam-fowler
added a commit
that referenced
this pull request
Apr 5, 2024
* make Credential Provider tests async * Make all AWSClient tests async * Make endpoint, service, middleware logging tests async * Make paginate, payload and waiter tests async * Last non async call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.